[GitHub] [spark] stczwd commented on a change in pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-11-10 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r520678496 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -976,4 +983,24 @@ trait CheckAnalysis extends P

[GitHub] [spark] stczwd commented on a change in pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-11-10 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r520663262 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Ap

[GitHub] [spark] stczwd commented on a change in pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-11-10 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r520546576 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -2066,13 +2069,68 @@ class DataSourceV2SQLSuite }

[GitHub] [spark] stczwd commented on a change in pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-11-09 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r520238163 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -2066,13 +2069,68 @@ class DataSourceV2SQLSuite }

[GitHub] [spark] stczwd commented on a change in pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-11-06 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r518653898 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -3415,10 +3415,10 @@ class AstBuilder(conf: SQLConf)

[GitHub] [spark] stczwd commented on a change in pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-11-06 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r518655126 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -551,3 +552,37 @@ case class ShowFunctions(

[GitHub] [spark] stczwd commented on a change in pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-27 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r495670079 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -551,3 +552,31 @@ case class ShowFunctions(

[GitHub] [spark] stczwd commented on a change in pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-27 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r495562634 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableAddPartitionExec.scala ## @@ -0,0 +1,62 @@ +/* + * Licensed

[GitHub] [spark] stczwd commented on a change in pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-25 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r494743750 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -551,3 +552,31 @@ case class ShowFunctions(

[GitHub] [spark] stczwd commented on a change in pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-24 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r494743750 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -551,3 +552,31 @@ case class ShowFunctions(

[GitHub] [spark] stczwd commented on a change in pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-08-05 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r466170214 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableAddPartitionExec.scala ## @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] [spark] stczwd commented on a change in pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-08-05 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r466011087 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableAddPartitionExec.scala ## @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] [spark] stczwd commented on a change in pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-08-05 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r465996986 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableAddPartitionExec.scala ## @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] [spark] stczwd commented on a change in pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-08-05 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r465999241 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Implicits.scala ## @@ -62,4 +74,31 @@ object DataSourc

[GitHub] [spark] stczwd commented on a change in pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-08-05 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r465996986 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableAddPartitionExec.scala ## @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] [spark] stczwd commented on a change in pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-08-05 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r465614538 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableAddPartitionExec.scala ## @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] [spark] stczwd commented on a change in pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-08-04 Thread GitBox
stczwd commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r465425990 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterTableDropPartitionExec.scala ## @@ -0,0 +1,58 @@ +/* + * Licensed