[GitHub] [spark] sunchao commented on a change in pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
sunchao commented on a change in pull request #29775: URL: https://github.com/apache/spark/pull/29775#discussion_r489996551 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -103,9 +103,9 @@ object Unwrap

[GitHub] [spark] sunchao commented on a change in pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
sunchao commented on a change in pull request #29775: URL: https://github.com/apache/spark/pull/29775#discussion_r489988859 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -103,9 +103,9 @@ object Unwrap

[GitHub] [spark] sunchao commented on a change in pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
sunchao commented on a change in pull request #29775: URL: https://github.com/apache/spark/pull/29775#discussion_r489792562 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -103,9 +103,9 @@ object Unwrap

[GitHub] [spark] sunchao commented on a change in pull request #29775: [SPARK-24994][SQL][FOLLOW-UP] Handle foldable, timezone and cleanup

2020-09-16 Thread GitBox
sunchao commented on a change in pull request #29775: URL: https://github.com/apache/spark/pull/29775#discussion_r489706969 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala ## @@ -184,7 +185,7 @@ object Unwrap