[GitHub] [spark] sunchao commented on a change in pull request #31476: [SPARK-34366][SQL] Add interface for DS v2 metrics

2021-02-05 Thread GitBox
sunchao commented on a change in pull request #31476: URL: https://github.com/apache/spark/pull/31476#discussion_r570505479 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/CustomMetric.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [spark] sunchao commented on a change in pull request #31476: [SPARK-34366][SQL] Add interface for DS v2 metrics

2021-02-04 Thread GitBox
sunchao commented on a change in pull request #31476: URL: https://github.com/apache/spark/pull/31476#discussion_r570625284 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/Scan.java ## @@ -102,4 +102,13 @@ default MicroBatchStream toMicroBatchStrea

[GitHub] [spark] sunchao commented on a change in pull request #31476: [SPARK-34366][SQL] Add interface for DS v2 metrics

2021-02-04 Thread GitBox
sunchao commented on a change in pull request #31476: URL: https://github.com/apache/spark/pull/31476#discussion_r570505479 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/CustomMetric.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Softwar