[GitHub] [spark] sunchao commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-14 Thread GitBox
sunchao commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879645593 @gengliangwang done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] sunchao commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-14 Thread GitBox
sunchao commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879623037 Thanks @dongjoon-hyun and @viirya ! I've rebased the PR and addressed the comments. Please take another look. With the current test suite it's pretty hard to add more

[GitHub] [spark] sunchao commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
sunchao commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879583404 thanks @gengliangwang - I opened #4 for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] sunchao commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
sunchao commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879512049 thanks @dongjoon-hyun - what do you think if I open a separate PR to do the refactoring on the test suite first? it will make the changes easier. -- This is an automated

[GitHub] [spark] sunchao commented on pull request #33330: [SPARK-36123][SQL] Parquet vectorized reader doesn't skip null values correctly

2021-07-13 Thread GitBox
sunchao commented on pull request #0: URL: https://github.com/apache/spark/pull/0#issuecomment-879455576 cc @dongjoon-hyun @viirya @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to