[GitHub] [spark] tdg5 commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

2021-11-30 Thread GitBox
tdg5 commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r759389734 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProviderSuite.scala ## @@ -68,12 +69,20 @@ class

[GitHub] [spark] tdg5 commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

2021-11-29 Thread GitBox
tdg5 commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r758587271 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/BasicConnectionProvider.scala ## @@ -48,4 +48,12 @@

[GitHub] [spark] tdg5 commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

2021-11-29 Thread GitBox
tdg5 commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r758587271 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/BasicConnectionProvider.scala ## @@ -48,4 +48,12 @@

[GitHub] [spark] tdg5 commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

2021-11-29 Thread GitBox
tdg5 commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r758510360 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/BasicConnectionProvider.scala ## @@ -48,4 +48,12 @@

[GitHub] [spark] tdg5 commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

2021-11-29 Thread GitBox
tdg5 commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r758551435 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/BasicConnectionProvider.scala ## @@ -48,4 +48,12 @@

[GitHub] [spark] tdg5 commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

2021-11-29 Thread GitBox
tdg5 commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r758551435 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/BasicConnectionProvider.scala ## @@ -48,4 +48,12 @@

[GitHub] [spark] tdg5 commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

2021-11-29 Thread GitBox
tdg5 commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r758512327 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcConnectionProvider.scala ## @@ -53,12 +53,25 @@ abstract class JdbcConnectionProvider {

[GitHub] [spark] tdg5 commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

2021-11-29 Thread GitBox
tdg5 commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r758511777 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProviderSuite.scala ## @@ -107,12 +124,50 @@

[GitHub] [spark] tdg5 commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

2021-11-29 Thread GitBox
tdg5 commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r758510360 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/BasicConnectionProvider.scala ## @@ -48,4 +48,12 @@

[GitHub] [spark] tdg5 commented on a change in pull request #34745: [WIP][SPARK-37391][SQL] JdbcConnectionProvider must indicate if it needs lock

2021-11-29 Thread GitBox
tdg5 commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r758508360 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcConnectionProvider.scala ## @@ -53,12 +53,25 @@ abstract class JdbcConnectionProvider {