[GitHub] [spark] techaddict commented on a diff in pull request #39225: [WIP][SPARK-41654][CONNECT][TESTS] doctests for pyspark.sqlconnect.window

2022-12-26 Thread GitBox
techaddict commented on code in PR #39225: URL: https://github.com/apache/spark/pull/39225#discussion_r1057398834 ## python/pyspark/sql/connect/window.py: ## @@ -201,7 +201,7 @@ def __repr__(self) -> str: return "WindowSpec(" + ", ".join(strs) + ")" -WindowSpec.__do

[GitHub] [spark] techaddict commented on a diff in pull request #39225: [WIP][SPARK-41654][CONNECT][TESTS] doctests for pyspark.sqlconnect.window

2022-12-26 Thread GitBox
techaddict commented on code in PR #39225: URL: https://github.com/apache/spark/pull/39225#discussion_r1057399255 ## python/pyspark/sql/connect/window.py: ## @@ -218,27 +218,201 @@ class Window: @staticmethod def partitionBy(*cols: Union["ColumnOrName", List["ColumnO

[GitHub] [spark] techaddict commented on a diff in pull request #39225: [WIP][SPARK-41654][CONNECT][TESTS] doctests for pyspark.sqlconnect.window

2022-12-27 Thread GitBox
techaddict commented on code in PR #39225: URL: https://github.com/apache/spark/pull/39225#discussion_r1057958961 ## python/pyspark/sql/connect/window.py: ## @@ -242,3 +243,46 @@ def rangeBetween(start: int, end: int) -> "WindowSpec": Window.__doc__ = PySparkWindow.__doc__