tgravescs commented on a change in pull request #30186:
URL: https://github.com/apache/spark/pull/30186#discussion_r516080247
##########
File path:
core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
##########
@@ -86,6 +86,22 @@ <h4 class="title-table">Executors</h4>
<span data-toggle="tooltip" data-placement="top"
title="Memory used / total available memory for off heap
storage of data like RDD partitions cached in memory.">
Off Heap Storage Memory</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak onHeap / OffHeap memory used by JVM.">
+ Peak JVM Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak execution onHeap / OffHeap memory used by JVM.">
+ Peak Execution Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak storage onHeap / OffHeap memory used by JVM.">
Review comment:
I think we should expand this to be "Peak onHeap/ OffHeap memory used
for storage of data like RDD partitions cached in memory"
##########
File path:
core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
##########
@@ -86,6 +86,22 @@ <h4 class="title-table">Executors</h4>
<span data-toggle="tooltip" data-placement="top"
title="Memory used / total available memory for off heap
storage of data like RDD partitions cached in memory.">
Off Heap Storage Memory</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak onHeap / OffHeap memory used by JVM.">
+ Peak JVM Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak execution onHeap / OffHeap memory used by JVM.">
Review comment:
Peak OnHeap/OffHeap memory used for execution. This refers to memory
used for computation in shuffles, joins, user data structures, etc. See the
Memory Management Overview documentation for more details.
##########
File path:
core/src/main/resources/org/apache/spark/ui/static/executorspage-template.html
##########
@@ -86,6 +86,22 @@ <h4 class="title-table">Executors</h4>
<span data-toggle="tooltip" data-placement="top"
title="Memory used / total available memory for off heap
storage of data like RDD partitions cached in memory.">
Off Heap Storage Memory</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak onHeap / OffHeap memory used by JVM.">
+ Peak JVM Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak execution onHeap / OffHeap memory used by JVM.">
+ Peak Execution Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak storage onHeap / OffHeap memory used by JVM.">
+ Peak Storage Memory OnHeap / OffHeap</span></th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top"
+ title="Peak direct / mapped pool memory used by JVM.">
Review comment:
Similarly I think we should explain more or point to java docs.
At least say this is direct byte buffers and mapped are memory-mapped or
perhaps better would be to point to java.nio:type=BufferPool,name=direct and
java.nio:type=BufferPool,name=mapped
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
