tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-663137078
merged to master, thanks @venkata91
This is an automated message from the Apache Git Service.
To respond to t
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-662458128
@venkata91 I assume your updates keep doing rebase? If possible its great
if you can just do up merges because doing rebases makes seeing the diffs
between requested change
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-659595794
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-659428051
Sorry that failure might be related to
https://issues.apache.org/jira/browse/SPARK-32287 I kicked it again
Th
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-659426971
org.apache.spark.ExecutorAllocationManagerSuite failed in the GitHub Actions
please take a look
This is an au
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-658974291
you can make a common function that has most of the code that gets called
from 2 separate tests. one test passes with dynamic allocation on, the other
with it off. that will r
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-658951229
yes we have a test in TaskSchedulerImplSuite that checks to make sure it
aborted, but I don't think it covers when dynamic allocation on, so it doesn't
hit your new code. So
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-658176997
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-658177196
I still need to look at your changes as well, haven't had time yet
This is an automated message from the Apach
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-657686732
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-656879502
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-656676553
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-649532575
yes its possible, I saw some issues on a few other pro although it was with
different parts. It maybe early next week before I can review.
---
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-649017016
sorry haven't had a chance to look at your rework, I rekicked the checks as
it might have been transient issue.
--
tgravescs commented on pull request #28287:
URL: https://github.com/apache/spark/pull/28287#issuecomment-619031231
it might have been discussions no on PR or buried in comments, I don't have
time to go looking. there are many different conditions to consider. The main
one we were focusing
15 matches
Mail list logo
