toujours33 commented on a change in pull request #32948:
URL: https://github.com/apache/spark/pull/32948#discussion_r654101887
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
##########
@@ -482,7 +482,7 @@ class SparkSubmitSuite
val (childArgs, classpath, conf, mainClass) =
submit.prepareSubmitEnvironment(appArgs)
val childArgsMap = childArgs.grouped(2).map(a => a(0) -> a(1)).toMap
- childArgsMap.get("--primary-java-resource") should be
(Some("file:/home/thejar.jar"))
+ childArgsMap.get("--primary-java-resource").get should endWith
("file:/home/thejar.jar")
Review comment:
Sorry, i commited the wrong code.
Thanks for your correcting, will fix it soon
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
##########
@@ -482,7 +482,7 @@ class SparkSubmitSuite
val (childArgs, classpath, conf, mainClass) =
submit.prepareSubmitEnvironment(appArgs)
val childArgsMap = childArgs.grouped(2).map(a => a(0) -> a(1)).toMap
- childArgsMap.get("--primary-java-resource") should be
(Some("file:/home/thejar.jar"))
+ childArgsMap.get("--primary-java-resource").get should endWith
("file:/home/thejar.jar")
Review comment:
@LuciferYang For sure, I'm running all cases on MacOs to check if there
are other failed cases like this. Before that, this pr will temporarily marked
as draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
