turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-565322918
> @turboFei Hi, could you address the review comments? This is good to have
and seems close to be merged
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-552833394
rebased.
This is an automated message from
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-551061010
retest this please.
This is an automated
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-536202062
> > In this PR, if a path is contained in processing, it would not be added
into listing.
>
> But
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-535836589
> By unblocking the cleanForLogs call, you also unblock the cleaner task
which may run after it. I didn't see
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-535820833
> By unblocking the `cleanForLogs` call, you also unblock the cleaner task
which may run after it. I didn't
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-535371948
> Seems good to me.
> @turboFei Have you tested the changes manually?
I have tested it for a week,
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-535316346
@cloud-fan Could you help take a look?
This
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-533577212
I just add some comment and rename a method, which would not impact the
test result.
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-533379236
I just modify the a method from protected to private in new commit, it would
not impact the test result.
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-532752969
gentle ping @dongjoon-hyun @HyukjinKwon
turboFei commented on issue #25797: [SPARK-29043][Core] Improve the concurrent
performance of History Server
URL: https://github.com/apache/spark/pull/25797#issuecomment-531606700
retest please
This is an automated message
12 matches
Mail list logo