[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-31 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1571327090 thanks all !!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-25 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1562455824 > I can also help with a use case for this, usually the submission client is on a single environment (Lets say we have it on cloud), and with spark on k8s, we can easily run jobs in diff

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-22 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1558506309 > Maybe we shall treat it like hive configurations or other third-party components to reduce the maintenance burden and complexity of the deployment. I believe different companies

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-22 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1558479516 gentle ping @yaooqinn @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-21 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1556452364 > And putting and locating extra configuration files in SPARK_HOME/conf is also a suggested way from our docs, so is this step necessary? I think it is necessary. Hadoop and

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-17 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1552365072 gentle ping @dongjoon-hyun would you like to review again? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-17 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-155146 thanks @advancedxy add more UT to check additionalPodSystemProperties and executor pod. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-17 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1551118696 the UT has passed, gentle ping @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-17 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1550976280 > this PR doesn't create new ConfigMaps, it either uses a user pre-set config map (no creation) or just reuse the config map created by driver which is created if necessary. yes,

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-16 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1550791604 thanks for comments, I will check it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-16 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1549820782 seems the k8s integration testing is stuck, will check this pr in our dev hadoop cluster tomorrow. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [spark] turboFei commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

2023-05-15 Thread via GitHub
turboFei commented on PR #41181: URL: https://github.com/apache/spark/pull/41181#issuecomment-1549024117 > would you mind updating "Does this PR introduce any user-facing change?" updated -- This is an automated message from the Apache Git Service. To respond to the message, please