[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-21 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r637228133 ## File path: python/pyspark/pandas/tests/data_type_ops/test_date_ops.py ## @@ -60,7 +61,9 @@ def test_sub(self): with option_context("compute.ops

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-21 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r637311351 ## File path: python/pyspark/pandas/tests/data_type_ops/test_num_ops.py ## @@ -30,6 +34,14 @@ class NumOpsTest(PandasOnSparkTestCase, TestCasesUtils):

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-21 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r637323275 ## File path: python/pyspark/pandas/tests/data_type_ops/test_num_ops.py ## @@ -42,7 +54,12 @@ def test_add(self): self.assertRaises(TypeEr

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-21 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r637328527 ## File path: python/pyspark/pandas/data_type_ops/boolean_ops.py ## @@ -26,3 +46,183 @@ class BooleanOps(DataTypeOps): @property def pretty_name(

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-21 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r637332388 ## File path: python/pyspark/pandas/data_type_ops/boolean_ops.py ## @@ -15,7 +15,27 @@ # limitations under the License. # -from pyspark.pandas.data_typ

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-21 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r637338469 ## File path: python/pyspark/pandas/data_type_ops/num_ops.py ## @@ -16,31 +16,46 @@ # import numbers -from typing import TYPE_CHECKING, Union +from typ

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-21 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r637338960 ## File path: python/pyspark/pandas/tests/data_type_ops/test_boolean_ops.py ## @@ -33,107 +35,148 @@ def pser(self): def psser(self): return

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-22 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r637311351 ## File path: python/pyspark/pandas/tests/data_type_ops/test_num_ops.py ## @@ -30,6 +34,14 @@ class NumOpsTest(PandasOnSparkTestCase, TestCasesUtils):

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-24 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r638207153 ## File path: python/pyspark/pandas/data_type_ops/boolean_ops.py ## @@ -50,7 +50,7 @@ def pretty_name(self) -> str: def add(self, left, right) -> Unio

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-24 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r638212053 ## File path: python/pyspark/pandas/data_type_ops/boolean_ops.py ## @@ -15,7 +15,27 @@ # limitations under the License. # -from pyspark.pandas.data_typ

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-24 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r638307070 ## File path: python/pyspark/pandas/data_type_ops/num_ops.py ## @@ -40,16 +40,19 @@ from pyspark.pandas.series import Series # noqa: F401 (SPARK-3494

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-24 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r638314268 ## File path: python/pyspark/pandas/data_type_ops/num_ops.py ## @@ -40,16 +40,19 @@ from pyspark.pandas.series import Series # noqa: F401 (SPARK-3494

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-24 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r638330196 ## File path: python/pyspark/pandas/data_type_ops/boolean_ops.py ## @@ -26,3 +38,136 @@ class BooleanOps(DataTypeOps): @property def pretty_name(

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-25 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r639154215 ## File path: python/pyspark/pandas/data_type_ops/boolean_ops.py ## @@ -26,3 +39,144 @@ class BooleanOps(DataTypeOps): @property def pretty_name(

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-25 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r639195854 ## File path: python/pyspark/pandas/data_type_ops/boolean_ops.py ## @@ -26,3 +39,144 @@ class BooleanOps(DataTypeOps): @property def pretty_name(

[GitHub] [spark] ueshin commented on a change in pull request #32611: [SPARK-35314][PYTHON] Support arithmetic operations against bool IndexOpsMixin

2021-05-27 Thread GitBox
ueshin commented on a change in pull request #32611: URL: https://github.com/apache/spark/pull/32611#discussion_r640957750 ## File path: python/pyspark/pandas/tests/test_dataframe.py ## @@ -121,7 +121,7 @@ def test_extension_dtypes(self): psdf = ps.from_pandas(pdf)