[GitHub] [spark] ulysses-you commented on a change in pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-13 Thread GitBox
ulysses-you commented on a change in pull request #29423: URL: https://github.com/apache/spark/pull/29423#discussion_r469883959 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ## @@ -1005,7 +1006,8 @@ private[hive] object HiveClientI

[GitHub] [spark] ulysses-you commented on a change in pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-13 Thread GitBox
ulysses-you commented on a change in pull request #29423: URL: https://github.com/apache/spark/pull/29423#discussion_r469884015 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala ## @@ -137,4 +137,24 @@ class HiveSQLViewSuite exten

[GitHub] [spark] ulysses-you commented on a change in pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-13 Thread GitBox
ulysses-you commented on a change in pull request #29423: URL: https://github.com/apache/spark/pull/29423#discussion_r469969329 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ## @@ -1005,7 +1006,8 @@ private[hive] object HiveClientI

[GitHub] [spark] ulysses-you commented on a change in pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-13 Thread GitBox
ulysses-you commented on a change in pull request #29423: URL: https://github.com/apache/spark/pull/29423#discussion_r469976892 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ## @@ -731,6 +731,7 @@ abstract class SQLViewSuite extends Qu

[GitHub] [spark] ulysses-you commented on a change in pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-13 Thread GitBox
ulysses-you commented on a change in pull request #29423: URL: https://github.com/apache/spark/pull/29423#discussion_r469976892 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ## @@ -731,6 +731,7 @@ abstract class SQLViewSuite extends Qu

[GitHub] [spark] ulysses-you commented on a change in pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-13 Thread GitBox
ulysses-you commented on a change in pull request #29423: URL: https://github.com/apache/spark/pull/29423#discussion_r469976892 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ## @@ -731,6 +731,7 @@ abstract class SQLViewSuite extends Qu

[GitHub] [spark] ulysses-you commented on a change in pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-13 Thread GitBox
ulysses-you commented on a change in pull request #29423: URL: https://github.com/apache/spark/pull/29423#discussion_r469977908 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSQLViewSuite.scala ## @@ -137,4 +137,25 @@ class HiveSQLViewSuite exten