[GitHub] [spark] ulysses-you commented on a diff in pull request #36468: [SPARK-39106][SQL] Correct conditional expression constant folding

ulysses-you commented on code in PR #36468: URL: https://github.com/apache/spark/pull/36468#discussion_r866699096 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -52,22 +52,28 @@ object ConstantFolding extends Rule[LogicalPlan] {

[GitHub] [spark] ulysses-you commented on a diff in pull request #36468: [SPARK-39106][SQL] Correct conditional expression constant folding

ulysses-you commented on code in PR #36468: URL: https://github.com/apache/spark/pull/36468#discussion_r866809228 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -52,22 +52,28 @@ object ConstantFolding extends Rule[LogicalPlan] {

[GitHub] [spark] ulysses-you commented on a diff in pull request #36468: [SPARK-39106][SQL] Correct conditional expression constant folding

ulysses-you commented on code in PR #36468: URL: https://github.com/apache/spark/pull/36468#discussion_r867302077 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala: ## @@ -48,6 +48,8 @@ case class If(predicate: Expression, true

[GitHub] [spark] ulysses-you commented on a diff in pull request #36468: [SPARK-39106][SQL] Correct conditional expression constant folding

ulysses-you commented on code in PR #36468: URL: https://github.com/apache/spark/pull/36468#discussion_r867323315 ## sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-case.sql: ## @@ -67,14 +67,12 @@ SELECT '7' AS `None`, CASE WHEN rand() < udf(0) THEN 1 END

[GitHub] [spark] ulysses-you commented on a diff in pull request #36468: [SPARK-39106][SQL] Correct conditional expression constant folding

ulysses-you commented on code in PR #36468: URL: https://github.com/apache/spark/pull/36468#discussion_r868755295 ## sql/core/src/test/resources/sql-tests/inputs/ansi/conditional-functions.sql: ## @@ -1,6 +1,41 @@ -- Tests for conditional functions -CREATE TABLE t USING PARQUET

[GitHub] [spark] ulysses-you commented on a diff in pull request #36468: [SPARK-39106][SQL] Correct conditional expression constant folding

ulysses-you commented on code in PR #36468: URL: https://github.com/apache/spark/pull/36468#discussion_r868755471 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -52,23 +53,46 @@ object ConstantFolding extends Rule[LogicalPlan] {

[GitHub] [spark] ulysses-you commented on a diff in pull request #36468: [SPARK-39106][SQL] Correct conditional expression constant folding

ulysses-you commented on code in PR #36468: URL: https://github.com/apache/spark/pull/36468#discussion_r868755471 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -52,23 +53,46 @@ object ConstantFolding extends Rule[LogicalPlan] {

[GitHub] [spark] ulysses-you commented on a diff in pull request #36468: [SPARK-39106][SQL] Correct conditional expression constant folding

ulysses-you commented on code in PR #36468: URL: https://github.com/apache/spark/pull/36468#discussion_r868756052 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ## @@ -52,23 +53,46 @@ object ConstantFolding extends Rule[LogicalPlan] {

[GitHub] [spark] ulysses-you commented on a diff in pull request #36468: [SPARK-39106][SQL] Correct conditional expression constant folding

ulysses-you commented on code in PR #36468: URL: https://github.com/apache/spark/pull/36468#discussion_r869042405 ## sql/core/src/test/resources/sql-tests/inputs/ansi/conditional-functions.sql: ## @@ -1,6 +1,41 @@ -- Tests for conditional functions -CREATE TABLE t USING PARQUET