[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r893019308 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -734,11 +920,35 @@ case class Pmod( override def nullable:

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886799362 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala: ## @@ -3055,21 +3055,6 @@ class DataFrameSuite extends QueryTest assert(df2.isLocal) }

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886787746 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala: ## @@ -232,3 +216,33 @@ case class CheckOverflowInSum(

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886782440 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -778,16 +1002,24 @@ case class Pmod( val javaType =

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886781843 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,12 +622,27 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885533013 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,78 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885529640 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,78 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885462208 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,10 +621,26 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885457521 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -778,16 +999,26 @@ case class Pmod( val javaType =

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885450552 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,78 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885448733 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,78 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885447945 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,10 +621,26 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885317774 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -521,6 +651,7 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885315379 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,76 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885314882 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,76 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885314663 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -373,11 +457,24 @@ case class Subtract( override def

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885314377 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,76 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885199407 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala: ## @@ -60,7 +56,7 @@ import org.apache.spark.sql.types._ */ //

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885174282 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -323,11 +389,24 @@ case class Add( override def decimalMethod:

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884679581 ## sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q65.sf100/explain.txt: ## @@ -151,106 +152,110 @@ Functions [1]: [avg(revenue#21)]

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884623757 ## sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q65.sf100/explain.txt: ## @@ -151,106 +152,110 @@ Functions [1]: [avg(revenue#21)]

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884622294 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala: ## @@ -232,3 +216,32 @@ case class CheckOverflowInSum(

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884620911 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -323,11 +389,24 @@ case class Add( override def decimalMethod:

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884620087 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala: ## @@ -75,18 +80,17 @@ abstract class AverageBase )

[GitHub] [spark] ulysses-you commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884619319 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala: ## @@ -60,7 +56,7 @@ import org.apache.spark.sql.types._ */ //