[GitHub] [spark] ulysses-you commented on a diff in pull request #38739: [SPARK-41207][SQL] Fix BinaryArithmetic with negative scale

ulysses-you commented on code in PR #38739: URL: https://github.com/apache/spark/pull/38739#discussion_r1034221066 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecisionSuite.scala: ## @@ -276,9 +276,9 @@ class DecimalPrecisionSuite extends Analys

[GitHub] [spark] ulysses-you commented on a diff in pull request #38739: [SPARK-41207][SQL] Fix BinaryArithmetic with negative scale

ulysses-you commented on code in PR #38739: URL: https://github.com/apache/spark/pull/38739#discussion_r1031953045 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecisionSuite.scala: ## @@ -276,9 +276,9 @@ class DecimalPrecisionSuite extends Analys

[GitHub] [spark] ulysses-you commented on a diff in pull request #38739: [SPARK-41207][SQL] Fix BinaryArithmetic with negative scale

ulysses-you commented on code in PR #38739: URL: https://github.com/apache/spark/pull/38739#discussion_r1031054191 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecisionSuite.scala: ## @@ -276,9 +276,9 @@ class DecimalPrecisionSuite extends Analys

[GitHub] [spark] ulysses-you commented on a diff in pull request #38739: [SPARK-41207][SQL] Fix BinaryArithmetic with negative scale

ulysses-you commented on code in PR #38739: URL: https://github.com/apache/spark/pull/38739#discussion_r1031054191 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecisionSuite.scala: ## @@ -276,9 +276,9 @@ class DecimalPrecisionSuite extends Analys

[GitHub] [spark] ulysses-you commented on a diff in pull request #38739: [SPARK-41207][SQL] Fix BinaryArithmetic with negative scale

ulysses-you commented on code in PR #38739: URL: https://github.com/apache/spark/pull/38739#discussion_r1029960652 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecisionSuite.scala: ## @@ -276,9 +276,9 @@ class DecimalPrecisionSuite extends Analys

[GitHub] [spark] ulysses-you commented on a diff in pull request #38739: [SPARK-41207][SQL] Fix BinaryArithmetic with negative scale

ulysses-you commented on code in PR #38739: URL: https://github.com/apache/spark/pull/38739#discussion_r1028718134 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala: ## @@ -3532,6 +3532,49 @@ class DataFrameSuite extends QueryTest }.isEmpty) } }

[GitHub] [spark] ulysses-you commented on a diff in pull request #38739: [SPARK-41207][SQL] Fix BinaryArithmetic with negative scale

ulysses-you commented on code in PR #38739: URL: https://github.com/apache/spark/pull/38739#discussion_r1027952685 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -234,7 +234,17 @@ abstract class BinaryArithmetic extends BinaryOpe