[GitHub] [spark] ulysses-you commented on a diff in pull request #40589: [SPARK-38697][SQL] Extend SparkSessionExtensions to inject rules into AQE query stage optimizer

2023-03-31 Thread via GitHub
ulysses-you commented on code in PR #40589: URL: https://github.com/apache/spark/pull/40589#discussion_r1154054018 ## sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala: ## @@ -111,11 +112,12 @@ class SparkSessionExtensions { type FunctionDescription =

[GitHub] [spark] ulysses-you commented on a diff in pull request #40589: [SPARK-38697][SQL] Extend SparkSessionExtensions to inject rules into AQE query stage optimizer

2023-03-30 Thread via GitHub
ulysses-you commented on code in PR #40589: URL: https://github.com/apache/spark/pull/40589#discussion_r1154046952 ## sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala: ## @@ -1161,3 +1177,12 @@ object AddLimit extends Rule[LogicalPlan] { case _

[GitHub] [spark] ulysses-you commented on a diff in pull request #40589: [SPARK-38697][SQL] Extend SparkSessionExtensions to inject rules into AQE query stage optimizer

2023-03-30 Thread via GitHub
ulysses-you commented on code in PR #40589: URL: https://github.com/apache/spark/pull/40589#discussion_r1154034136 ## sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala: ## @@ -111,11 +112,12 @@ class SparkSessionExtensions { type FunctionDescription =

[GitHub] [spark] ulysses-you commented on a diff in pull request #40589: [SPARK-38697][SQL] Extend SparkSessionExtensions to inject rules into AQE query stage optimizer

2023-03-29 Thread via GitHub
ulysses-you commented on code in PR #40589: URL: https://github.com/apache/spark/pull/40589#discussion_r1152689151 ## sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveRulesHolder.scala: ## @@ -26,5 +26,6 @@ import org.apache.spark.sql.execution.SparkPlan