[GitHub] [spark] ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete

2019-11-06 Thread GitBox
ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete URL: https://github.com/apache/spark/pull/26365#issuecomment-550559488 Thanks for review, I will close this.

[GitHub] [spark] ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete

2019-11-04 Thread GitBox
ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete URL: https://github.com/apache/spark/pull/26365#issuecomment-549615896 @rezasafi Oh I see... pending the last review. ---

[GitHub] [spark] ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete

2019-11-04 Thread GitBox
ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete URL: https://github.com/apache/spark/pull/26365#issuecomment-549603010 Thanks for review. I agree your points otherwise. But If we not sure what will happen in other

[GitHub] [spark] ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete

2019-11-02 Thread GitBox
ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete URL: https://github.com/apache/spark/pull/26365#issuecomment-549101205 This catch just confirm `echo $PPID ` is support for current os . But not sure whether current os

[GitHub] [spark] ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete

2019-11-01 Thread GitBox
ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete URL: https://github.com/apache/spark/pull/26365#issuecomment-549002793 Also cc @maropu @dongjoon-hyun T

[GitHub] [spark] ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete

2019-11-01 Thread GitBox
ulysses-you commented on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete URL: https://github.com/apache/spark/pull/26365#issuecomment-549002568 cc @squito @rezasafi This is an