[GitHub] [spark] ulysses-you commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-12-11 Thread GitBox
ulysses-you commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-743691405 thanks for the discussion ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] ulysses-you commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-12-10 Thread GitBox
ulysses-you commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-742979319 thank you @HyukjinKwon , I have updated the guide doc with [921f9cf](https://github.com/apache/spark/pull/30481/commits/921f9cfc6191da49a8adff55fa9750a3874284a1). IMO it's

[GitHub] [spark] ulysses-you commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-12-09 Thread GitBox
ulysses-you commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-742225211 Logically, it affects 2 code place. 1. cancel by query timeout. 2. cancel by statement selft. But I'm ok to let it bind with query timeout since it's a more

[GitHub] [spark] ulysses-you commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-12-09 Thread GitBox
ulysses-you commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-742187204 @juliuszsompolski This disadvantage seems important. ThrfitServer is a long lived process, I believe it's better to give user a dynamic config during it running rather than

[GitHub] [spark] ulysses-you commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-12-09 Thread GitBox
ulysses-you commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-741748969 I agree with it can be a core config. But I'm eager to add it to ThriftServer firstly. In core/sql case, we have a way to enable this by set local property to true manual.

[GitHub] [spark] ulysses-you commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-12-08 Thread GitBox
ulysses-you commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-741375247 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] ulysses-you commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-12-07 Thread GitBox
ulysses-you commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-740363232 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] ulysses-you commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

2020-11-24 Thread GitBox
ulysses-you commented on pull request #30481: URL: https://github.com/apache/spark/pull/30481#issuecomment-733293754 cc @maropu @AngersZh @wangyum @HyukjinKwon This is an automated message from the Apache Git Service.