[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-25 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-578470042 Thanks for reviewing @zsxwing and thanks for your helping @xuanyuanking

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-17 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-575563311 Kindly ping @sarutak @dongjoon-hyun and @zsxwing This is an

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-14 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-574460387 Today, I will give a commit to fix ut failure. This is an

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-13 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-573962388 @HeartSaVioR Thanks for your review, I will give a commit to resolve comments.

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-12 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-573546090 retest this please. This is an automated message from the Apache

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-12 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-573484866 retest this please. This is an automated message from the Apache

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-08 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-572398951 After `44b0a37`: - done - fix `NaN` issue - switch the tab position between "Structure Streaming" and "SQL" -

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-06 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-571478108 After `c036cfb`: - Done - fix resolve `NaN` issue - fix wrong operationLabels - switch the tab position

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-03 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-570555720 Sorry for delay, I am working on this PR these days, and will complete it as soon as possible.

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-02 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-570488408 @HeartSaVioR Thanks for your comments. I am preparing a separate PR to add the `StreamingQueryListener` support for Structured

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-12-11 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-564834795 I have no time for now but could update this PR from the end of next week. Thanks for all reviews

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-11-21 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-557377114 Thanks for your code review. @xuanyuanking @sarutak @HeartSaVioR Here is a summarize of code change after `e30af98`: - remove

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-11-11 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-552699374 Thanks for your reviewing, I will fix all these comments latter. @xuanyuanking @sarutak

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-28 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-546846010 retest this please. This is an automated message from the Apache

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-24 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-545778271 retest this please. This is an automated message from the Apache

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-23 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-545378949 I've just updated the code, including: - refactor to better reuse code and reduce duplicate code references - add query

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-22 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-544925018 Add streaming query information on top.

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-22 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-544910213 @HeartSaVioR > I meant the graph between streaming tab and here would be quite similar, so curious it could be reused,

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-22 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-544855695 @HeartSaVioR Thanks for your feedback > It may be better to define a new event for SQL and pass through listener bus, so

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-22 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-544832998 retest this please. This is an automated message from the Apache

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-22 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-544823816 Currently, the streaming query page entry is in `SQL` tab. I am not sure whether we need to add a new `StreamingTab` as there is