venkata91 commented on pull request #30691:
URL: https://github.com/apache/spark/pull/30691#issuecomment-856296880
Gentle ping @mridulm @Ngone51 @otterc for additional reviews after the last
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message,
venkata91 commented on pull request #30691:
URL: https://github.com/apache/spark/pull/30691#issuecomment-854130092
> The changes look good to me. Can you fix the style errors @venkata91 ?
>
> +CC @Ngone51 for another pass.
> Also @attilapiros, @tgravescs FYI.
Fixed it.
--
venkata91 commented on pull request #30691:
URL: https://github.com/apache/spark/pull/30691#issuecomment-854130092
> The changes look good to me. Can you fix the style errors @venkata91 ?
>
> +CC @Ngone51 for another pass.
> Also @attilapiros, @tgravescs FYI.
Fixed it.
--
venkata91 commented on pull request #30691:
URL: https://github.com/apache/spark/pull/30691#issuecomment-852683589
> continuous-integration/appveyor/pr — AppVeyor build failed
This seems to be an unrelated failure. @mridulm Can you please try kicking
off another run?
--
This is an
venkata91 commented on pull request #30691:
URL: https://github.com/apache/spark/pull/30691#issuecomment-850045368
Addressed all the comments AFAIK, please review @mridulm @Victsm @Ngone51
@otterc
--
This is an automated message from the Apache Git Service.
To respond to the message,
venkata91 commented on pull request #30691:
URL: https://github.com/apache/spark/pull/30691#issuecomment-848180565
Addressed review comments, please review @mridulm @Victsm @Ngone51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
venkata91 commented on pull request #30691:
URL: https://github.com/apache/spark/pull/30691#issuecomment-832117404
Gentle ping @Ngone51 @tgravescs @mridulm @Victsm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
venkata91 commented on pull request #30691:
URL: https://github.com/apache/spark/pull/30691#issuecomment-828634232
Fixed the PR rebasing the latest master changes and also marked it as open
for review. cc @mridulm @Victsm @otterc @Ngone51
--
This is an automated message from the Apache