venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-963372486
@sarutak Oh. my bad. I think we have fix for this internally. In the
refactoring, I probably missed to incorporate that check. @thejdeep would help
fix the issue and post a
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-932437690
Created a doc JIRA - https://issues.apache.org/jira/browse/SPARK-36908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-931932370
@sarutak Gentle reminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-930405537
@sarutak Addressed both of your comments. Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-930405537
@sarutak Addressed both of your comments. Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-927347191
@sarutak Gentle reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-926001947
`StackOverflowError` is happening on the sql module which is not related to
this change I think. Will try to update again with the latest master to see if
this succeeds. cc
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-925237574
> Could you add updated screenshots to the **description** ?
@sarutak Updated the description with new screenshots of API output. Please
take a look again. Sorry for
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-918458484
Gentle reminder @sarutak Have addressed the review comments. Please take a
look.
--
This is an automated message from the Apache Git Service.
To respond to the message,
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-901272772
@sarutak Gentle reminder. I think we have only one last pending comment from
you. I am hoping to resolve it soon and get the changes merged. Thanks!!
--
This is an
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-897974311
@sarutak @AngersZh Gentle reminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-890443720
Gentle reminder @sarutak @AngersZh Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-887682089
> I think this class is still needed.
> How about SpeculationSummary instead of SpeculationStageSummary?
> Speculation is not about stages but tasks.
@sarutak
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-886088386
It seems like some pyspark tests are failing not related to this PR. cc
@sarutak
```Failed example:
sc.parallelize([1]).isEmpty()
Exception raised:
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-885821250
> > > Ah I see, currently we are populating killedTasksSummary in
SpeculationStageSummary only if the killed reason is another attempt succeeded.
For other reasons, we are
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-885415899
> > Ah I see, currently we are populating killedTasksSummary in
SpeculationStageSummary only if the killed reason is another attempt succeeded.
For other reasons, we are not
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-885391140
> > killedTaskSummary when original attempt succeeded -
https://user-images.githubusercontent.com/8871522/126575315-5e766870-eab4-4afc-a02f-ede63148692b.png
> >
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-885386967
@sarutak Gentle ping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-884578963
> @venkata91 I checked out this change and accessed `/speculationSummary`
but `killedTasksSummary` seems empty.
> Could you investigate the cause?
>
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-883545199
@sarutak @AngersZh Tests are passing fine now. Can you please take a
look again? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-882743479
> @venkata91
>
> > it seems like something is wrong with the Github actions on my account
therefore the tests are not able to run. I filed a support request with Github
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-882743479
> @venkata91
>
> > it seems like something is wrong with the Github actions on my account
therefore the tests are not able to run. I filed a support request with Github
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-882743479
> @venkata91
>
> > it seems like something is wrong with the Github actions on my account
therefore the tests are not able to run. I filed a support request with Github
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-882008124
> Some tests seem to fail. Could you fix them?
@sarutak it seems like something is wrong with the Github actions on my
account therefore the tests are not able to run.
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-881909197
@sarutak @AngersZh can you please take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-879579744
> @venkata91 Could you fix the style issue first?
>
> ```
> [error]
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-879141226
> > @venkata91 I checked out your change and run it on GA on my account but
it fails to build.
> > ```
> > [error]
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-877411510
> @venkata91 Sorry if I'm confusing you. I told you two things (your change
seems to fail to build and please enable GA on your account to run test).
> The failure and that
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-877409027
@sarutak I tried compiling locally it passed fine, will check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-877326021
> @venkata91 I checked out your change and run it on GA on my account but it
fails to build.
>
> ```
> [error]
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-876907600
> @venkata91
> > @sarutak It seems like Github actions is disabled for my fork. I have
requested them to enable it. Just curious, why do I need to enable it for my
fork
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-876873242
> As @AngersZh suggests, please show the screenshot from which we can
confirm the change.
> Also, please enable GitHub Actions on your repository.
@sarutak It
venkata91 commented on pull request #33253:
URL: https://github.com/apache/spark/pull/33253#issuecomment-876871451
