[GitHub] [spark] viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal

2020-01-21 Thread GitBox
viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal URL: https://github.com/apache/spark/pull/26881#discussion_r369109161 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ## @@ -1

[GitHub] [spark] viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal

2020-01-12 Thread GitBox
viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal URL: https://github.com/apache/spark/pull/26881#discussion_r365644301 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ## @@ -134,10

[GitHub] [spark] viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode

2020-01-10 Thread GitBox
viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode URL: https://github.com/apache/spark/pull/26881#discussion_r365484693 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/liter

[GitHub] [spark] viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode

2020-01-10 Thread GitBox
viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode URL: https://github.com/apache/spark/pull/26881#discussion_r365484980 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ##

[GitHub] [spark] viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode

2020-01-10 Thread GitBox
viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode URL: https://github.com/apache/spark/pull/26881#discussion_r365484693 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/liter

[GitHub] [spark] viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode

2020-01-10 Thread GitBox
viirya commented on a change in pull request #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal under ansi mode URL: https://github.com/apache/spark/pull/26881#discussion_r365484455 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala #