[GitHub] [spark] viirya commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-24 Thread GitBox
viirya commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r460136310 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java ## @@ -61,4 +78,62 @@ public MetricSet shuffleMe

[GitHub] [spark] viirya commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-23 Thread GitBox
viirya commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r459734646 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -492,20 +494,26 @@ private[spark] class BlockManager( registerWi

[GitHub] [spark] viirya commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-23 Thread GitBox
viirya commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r459673702 ## File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala ## @@ -466,42 +464,51 @@ final class ShuffleBlockFetcherItera

[GitHub] [spark] viirya commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-23 Thread GitBox
viirya commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r459671216 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java ## @@ -61,4 +78,62 @@ public MetricSet shuffleMe

[GitHub] [spark] viirya commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-23 Thread GitBox
viirya commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r459649979 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1415,10 +1415,16 @@ package object config { private[spark] val