[GitHub] [spark] viirya commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-04 Thread GitBox
viirya commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r465502978 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,61 @@ abstract class JdbcDialect extends Serializable

[GitHub] [spark] viirya commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-04 Thread GitBox
viirya commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r465501617 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,61 @@ abstract class JdbcDialect extends Serializable

[GitHub] [spark] viirya commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
viirya commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464791662 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -900,10 +889,52 @@ object JdbcUtils extends Lo

[GitHub] [spark] viirya commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
viirya commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464791154 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -900,10 +889,52 @@ object JdbcUtils extends Lo

[GitHub] [spark] viirya commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
viirya commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464790560 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,62 @@ abstract class JdbcDialect extends Serializable

[GitHub] [spark] viirya commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-08-03 Thread GitBox
viirya commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r464788259 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -900,10 +889,52 @@ object JdbcUtils extends Lo

[GitHub] [spark] viirya commented on a change in pull request #29324: [SPARK-32402][SQL] Implement ALTER TABLE in JDBC Table Catalog

2020-07-31 Thread GitBox
viirya commented on a change in pull request #29324: URL: https://github.com/apache/spark/pull/29324#discussion_r463914794 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -184,15 +189,56 @@ abstract class JdbcDialect extends Serializable