[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r506578657 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2067,6 +2067,13 @@ class Dataset[T] private[sql]( * // +++---

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r506578485 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,188 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-15 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r505677527 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,190 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r504936830 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,190 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r504799643 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,190 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r504798080 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,190 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r504796446 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,190 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r504794611 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2740,6 +2740,19 @@ object SQLConf { .booleanConf

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-10 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r502837273 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2721,6 +2721,16 @@ object SQLConf { .booleanConf

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-10 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r502837273 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2721,6 +2721,16 @@ object SQLConf { .booleanConf

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-05 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r500034164 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2721,6 +2721,16 @@ object SQLConf { .booleanConf

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-05 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r500033312 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-05 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r499980671 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-05 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r499980569 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-05 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r499980265 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-05 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r499980265 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-05 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r499979944 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2721,6 +2721,16 @@ object SQLConf { .booleanConf

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-22 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r493101256 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-22 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r493103615 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-22 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r493101256 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-21 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r491711425 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-20 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r491711425 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-19 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r491638577 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,202 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-19 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r491637817 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-19 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r491637762 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -50,18 +189,29 @@ object ResolveUnion extends Ru

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489799250 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489799141 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489542367 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489540174 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489540466 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489539877 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,168 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489539121 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -50,18 +189,29 @@ object ResolveUnion extends Ru

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-16 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r489537683 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -50,18 +189,29 @@ object ResolveUnion extends Ru

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r488324577 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -507,33 +507,156 @@ class DataFrameSetOperationsSuite e

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r488314435 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class StringToMap

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r488314435 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class StringToMap

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r488314435 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class StringToMap

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r488155092 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class StringToMap

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-14 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r488109612 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -507,33 +507,156 @@ class DataFrameSetOperationsSuite e

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-13 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r487662093 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,107 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-13 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r487645676 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,107 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-13 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r487647961 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,107 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-13 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r487645676 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,107 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-12 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r487484664 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/StructTypeSuite.scala ## @@ -103,4 +105,112 @@ class StructTypeSuite extends SparkFun

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-12 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r487484292 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/StructTypeSuite.scala ## @@ -103,4 +105,112 @@ class StructTypeSuite extends SparkFun

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-12 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r487484192 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/StructTypeSuite.scala ## @@ -103,4 +105,112 @@ class StructTypeSuite extends SparkFun

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-12 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r487463931 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -536,4 +536,71 @@ class DataFrameSetOperationsSuite ext

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-12 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r487457983 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,101 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-12 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r486761719 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -536,4 +536,71 @@ class DataFrameSetOperationsSuite ext

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-12 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r486761719 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -536,4 +536,71 @@ class DataFrameSetOperationsSuite ext

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-12 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r486761719 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -536,4 +536,71 @@ class DataFrameSetOperationsSuite ext

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-10 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r486762671 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,101 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-10 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r486761719 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -536,4 +536,71 @@ class DataFrameSetOperationsSuite ext

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-02 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r482709060 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ## @@ -641,4 +641,30 @@ object StructType extends AbstractDataType {

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-02 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r482707006 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -50,18 +122,29 @@ object ResolveUnion extends Ru

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-02 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r482707069 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,101 @@ package org.apache.spark.sq

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-02 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r482706359 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class StringToMap

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480793907 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -546,7 +547,8 @@ case class StringToMap

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480527411 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,97 @@ package org.apache.spark.sql

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480500164 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/StructTypeSuite.scala ## @@ -103,4 +104,30 @@ class StructTypeSuite extends SparkFunS

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480239099 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala ## @@ -17,29 +17,97 @@ package org.apache.spark.sql

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480238080 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ## @@ -641,4 +641,30 @@ object StructType extends AbstractDataType {

[GitHub] [spark] viirya commented on a change in pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-08-31 Thread GitBox
viirya commented on a change in pull request #29587: URL: https://github.com/apache/spark/pull/29587#discussion_r480237210 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ## @@ -641,4 +641,30 @@ object StructType extends AbstractDataType {