viirya commented on a change in pull request #29846:
URL: https://github.com/apache/spark/pull/29846#discussion_r493947730
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesVolumeSpec.scala
##########
@@ -21,7 +21,10 @@ private[spark] sealed trait KubernetesVolumeSpecificConf
private[spark] case class KubernetesHostPathVolumeConf(hostPath: String)
extends KubernetesVolumeSpecificConf
-private[spark] case class KubernetesPVCVolumeConf(claimName: String)
+private[spark] case class KubernetesPVCVolumeConf(
+ claimName: String,
+ storageClass: Option[String] = None,
+ size: Option[String] = None)
Review comment:
Do `storageClass` and `size` must be both defined or empty? Can we only
define `storageClass` but without `size`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
