viirya commented on a change in pull request #30413:
URL: https://github.com/apache/spark/pull/30413#discussion_r529776310
##
File path: python/pyspark/mllib/util.py
##
@@ -313,24 +363,30 @@ def convertMatrixColumnsToML(dataset, *cols):
return callMLlibFunc("convertMat
viirya commented on a change in pull request #30413:
URL: https://github.com/apache/spark/pull/30413#discussion_r529776085
##
File path: python/pyspark/mllib/util.py
##
@@ -273,24 +317,30 @@ def convertVectorColumnsFromML(dataset, *cols):
return callMLlibFunc("convertV
viirya commented on a change in pull request #30413:
URL: https://github.com/apache/spark/pull/30413#discussion_r529771614
##
File path: python/pyspark/mllib/stat/_statistics.py
##
@@ -65,11 +65,19 @@ def colStats(rdd):
"""
Computes column-wise summary statist
viirya commented on a change in pull request #30413:
URL: https://github.com/apache/spark/pull/30413#discussion_r529769785
##
File path: python/pyspark/mllib/regression.py
##
@@ -224,11 +234,13 @@ def _regression_train_wrapper(train_func, modelClass,
data, initial_weights):
viirya commented on a change in pull request #30413:
URL: https://github.com/apache/spark/pull/30413#discussion_r529762661
##
File path: python/pyspark/mllib/clustering.py
##
@@ -499,32 +554,36 @@ class GaussianMixture(object):
.. versionadded:: 1.3.0
"""
+
@cl
viirya commented on a change in pull request #30413:
URL: https://github.com/apache/spark/pull/30413#discussion_r529113536
##
File path: python/pyspark/mllib/classification.py
##
@@ -501,53 +525,59 @@ def load(cls, sc, path):
class SVMWithSGD(object):
"""
+Train a S
viirya commented on a change in pull request #30413:
URL: https://github.com/apache/spark/pull/30413#discussion_r529108779
##
File path: python/pyspark/mllib/classification.py
##
@@ -88,20 +88,26 @@ class LogisticRegressionModel(LinearClassificationModel):
Classification m
