[GitHub] [spark] viirya commented on a change in pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when explode with CreateArray/CreateMap

2020-12-01 Thread GitBox
viirya commented on a change in pull request #30504: URL: https://github.com/apache/spark/pull/30504#discussion_r533599029 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala ## @@ -263,4 +263,19 @@ class

[GitHub] [spark] viirya commented on a change in pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when explode with CreateArray/CreateMap

2020-12-01 Thread GitBox
viirya commented on a change in pull request #30504: URL: https://github.com/apache/spark/pull/30504#discussion_r533155787 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ## @@ -48,6 +48,9 @@ object ConstantFolding extends

[GitHub] [spark] viirya commented on a change in pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when explode with CreateArray/CreateMap

2020-11-25 Thread GitBox
viirya commented on a change in pull request #30504: URL: https://github.com/apache/spark/pull/30504#discussion_r530608975 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -30,6 +30,13 @@ import