[GitHub] [spark] viirya commented on a change in pull request #32699: [SPARK-35560][SQL] Remove redundant subexpression evaluation in nested subexpressions

viirya commented on a change in pull request #32699: URL: https://github.com/apache/spark/pull/32699#discussion_r643254798 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2882,6 +2882,31 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] viirya commented on a change in pull request #32699: [SPARK-35560][SQL] Remove redundant subexpression evaluation in nested subexpressions

viirya commented on a change in pull request #32699: URL: https://github.com/apache/spark/pull/32699#discussion_r642617321 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ## @@ -1039,21 +1039,25 @@ class

[GitHub] [spark] viirya commented on a change in pull request #32699: [SPARK-35560][SQL] Remove redundant subexpression evaluation in nested subexpressions

viirya commented on a change in pull request #32699: URL: https://github.com/apache/spark/pull/32699#discussion_r642314197 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ## @@ -1068,11 +1072,19 @@ class