[GitHub] [spark] viirya commented on a diff in pull request #37165: [SPARK-39699][SQL] Make CollapseProject smarter about collection creation expressions

2022-07-12 Thread GitBox
viirya commented on code in PR #37165: URL: https://github.com/apache/spark/pull/37165#discussion_r919607195 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1011,24 +1011,92 @@ object CollapseProject extends Rule[LogicalPlan] with

[GitHub] [spark] viirya commented on a diff in pull request #37165: [SPARK-39699][SQL] Make CollapseProject smarter about collection creation expressions

2022-07-12 Thread GitBox
viirya commented on code in PR #37165: URL: https://github.com/apache/spark/pull/37165#discussion_r919605415 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1011,24 +1011,92 @@ object CollapseProject extends Rule[LogicalPlan] with

[GitHub] [spark] viirya commented on a diff in pull request #37165: [SPARK-39699][SQL] Make CollapseProject smarter about collection creation expressions

2022-07-12 Thread GitBox
viirya commented on code in PR #37165: URL: https://github.com/apache/spark/pull/37165#discussion_r919605135 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala: ## @@ -659,7 +659,7 @@ case class WithField(name: String, valExpr: