[GitHub] [spark] viirya commented on a diff in pull request #40506: [SPARK-42881][SQL] Codegen Support for get_json_object

2023-07-13 Thread via GitHub
viirya commented on code in PR #40506: URL: https://github.com/apache/spark/pull/40506#discussion_r1263209639 ## sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala: ## @@ -1392,4 +1393,25 @@ class JsonFunctionsSuite extends QueryTest with SharedSparkSession {

[GitHub] [spark] viirya commented on a diff in pull request #40506: [SPARK-42881][SQL] Codegen Support for get_json_object

2023-07-13 Thread via GitHub
viirya commented on code in PR #40506: URL: https://github.com/apache/spark/pull/40506#discussion_r1263204348 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala: ## @@ -140,18 +135,114 @@ case class GetJsonObject(json: Expression, path

[GitHub] [spark] viirya commented on a diff in pull request #40506: [SPARK-42881][SQL] Codegen Support for get_json_object

2023-07-13 Thread via GitHub
viirya commented on code in PR #40506: URL: https://github.com/apache/spark/pull/40506#discussion_r1263203372 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala: ## @@ -140,18 +135,114 @@ case class GetJsonObject(json: Expression, path

[GitHub] [spark] viirya commented on a diff in pull request #40506: [SPARK-42881][SQL] Codegen Support for get_json_object

2023-07-11 Thread via GitHub
viirya commented on code in PR #40506: URL: https://github.com/apache/spark/pull/40506#discussion_r1260279671 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala: ## @@ -140,18 +135,92 @@ case class GetJsonObject(json: Expression, path:

[GitHub] [spark] viirya commented on a diff in pull request #40506: [SPARK-42881][SQL] Codegen Support for get_json_object

2023-07-11 Thread via GitHub
viirya commented on code in PR #40506: URL: https://github.com/apache/spark/pull/40506#discussion_r1260277539 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala: ## @@ -140,18 +135,92 @@ case class GetJsonObject(json: Expression, path: