[GitHub] [spark] viirya commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns

2019-08-26 Thread GitBox
viirya commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns URL: https://github.com/apache/spark/pull/25570#issuecomment-525046110 retest this please. This is an

[GitHub] [spark] viirya commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns

2019-08-26 Thread GitBox
viirya commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns URL: https://github.com/apache/spark/pull/25570#issuecomment-524845828 Btw, in the original JIRA comment, someone claims that Hive supports duplicate column names. I want

[GitHub] [spark] viirya commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns

2019-08-26 Thread GitBox
viirya commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns URL: https://github.com/apache/spark/pull/25570#issuecomment-524844659 hmm I am not sure if ALTER VIEW AS should take the schema of the new query, or it should keep

[GitHub] [spark] viirya commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns

2019-08-26 Thread GitBox
viirya commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns URL: https://github.com/apache/spark/pull/25570#issuecomment-524756546 > > have > > ALTER VIEW AS gets its schema from the new SELECT query provided. So it is not

[GitHub] [spark] viirya commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns

2019-08-23 Thread GitBox
viirya commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns URL: https://github.com/apache/spark/pull/25570#issuecomment-524498521 I'd suggest to use predefined PR description template. cc @HyukjinKwon