viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-919308510
#33989 seems a promising direction. Close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-875177916
Hmm, I looked at `isSharedClass`, looks like `common-lang3`, orc, etc. are
already non-shared classes.
--
This is an automated message from the Apache Git Service.
To respond t
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-875060042
> Oh I didn't even realize that Spark is using `hive-exec-core` jar. Does
that mean it doesn't take advantage of the Guava shading from Hive 2.3.8+ at
all?
Yea, I'm afraid
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-873359259
Encountered some issues.
Although we can switch to hive-exec without classifier (shaded version) to
get rid of above guava version issue, the shaded hive-exec contains (wit
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-872735918
Hmm, from the failed tests below:
org.apache.spark.sql.hive.DataSourceWithHiveMetastoreCatalogSuite
org.apache.spark.sql.hive.HiveExternalCatalogSuite
org.apache.spark
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-871990967
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-871122684
I'm not against to this point. I can change to latest guava and see what CI
tells.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-871101530
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-870850274
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-870811211
try this again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-694355931
Isn't HADOOP-14284 resolved as Invalid?
This is an automated message from the Apache Git Service.
To respond to t
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-670608710
@dongjoon-hyun Thanks for the comment. Yeah, it doesn't make sense to
upgrade to Hive 4 in short or midterm. I'm working on upgrade Guava 27 and
shading Guava in Hive too. I hope
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-668878065
I did some tests. Few changes are required to pass the failed Hive tests:
1. Shading Guava at hive-exec packaging and a few code changes to
hive-common and hive-exec regard
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-668116815
Opened https://issues.apache.org/jira/browse/HIVE-23980 and see if Hive
people has some ideas.
This is an automa
viirya commented on pull request #29326:
URL: https://github.com/apache/spark/pull/29326#issuecomment-667801138
It is a trouble that hive-exec uses a method that became package-private
since Guava version 20. So there is incompatibility with Guava versions > 19.0.
```
sbt.ForkMain
15 matches
Mail list logo
