[GitHub] [spark] viirya commented on pull request #31432: [SPARK-34324][SQL] FileTable should not list TRUNCATE in capabilities by default

2021-02-02 Thread GitBox
viirya commented on pull request #31432: URL: https://github.com/apache/spark/pull/31432#issuecomment-771481739 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [spark] viirya commented on pull request #31432: [SPARK-34324][SQL] FileTable should not list TRUNCATE in capabilities by default

2021-02-02 Thread GitBox
viirya commented on pull request #31432: URL: https://github.com/apache/spark/pull/31432#issuecomment-771923831 Thanks. Merging to master. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] viirya commented on pull request #31432: [SPARK-34324][SQL] FileTable should not list TRUNCATE in capabilities by default

2021-02-02 Thread GitBox
viirya commented on pull request #31432: URL: https://github.com/apache/spark/pull/31432#issuecomment-771503216 > do users hit any query failure or wrong result when file source v2 is enabled? Currently, I don't see any place checking table truncation capability by `TableHelper.supp

[GitHub] [spark] viirya commented on pull request #31432: [SPARK-34324][SQL] FileTable should not list TRUNCATE in capabilities by default

2021-02-02 Thread GitBox
viirya commented on pull request #31432: URL: https://github.com/apache/spark/pull/31432#issuecomment-771487515 > Looks reasonable. Does it cause any user-facing problems? IIUC, `FileTable` is not a public API.

[GitHub] [spark] viirya commented on pull request #31432: [SPARK-34324][SQL] FileTable should not list TRUNCATE in capabilities by default

2021-02-02 Thread GitBox
viirya commented on pull request #31432: URL: https://github.com/apache/spark/pull/31432#issuecomment-771481739 cc @cloud-fan @sunchao @dongjoon-hyun This is an automated message from the Apache Git Service. To respond to th