[GitHub] [spark] viirya edited a comment on pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-10-04 Thread GitBox
viirya edited a comment on pull request #29587: URL: https://github.com/apache/spark/pull/29587#issuecomment-703304346 ping @maropu @dongjoon-hyun @cloud-fan Could you help review this again? Thanks. This is an automated mes

[GitHub] [spark] viirya edited a comment on pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-21 Thread GitBox
viirya edited a comment on pull request #29587: URL: https://github.com/apache/spark/pull/29587#issuecomment-695811361 @maropu @dongjoon-hyun @cloud-fan Spent some time fixing the optimization issue https://github.com/apache/spark/pull/29587#discussion_r489466321. This is ready for review

[GitHub] [spark] viirya edited a comment on pull request #29587: [SPARK-32376][SQL] Make unionByName null-filling behavior work with struct columns

2020-09-20 Thread GitBox
viirya edited a comment on pull request #29587: URL: https://github.com/apache/spark/pull/29587#issuecomment-695811361 @maropu @dongjoon-hyun @cloud-fan Spent some time fixing the optimization issue https://github.com/apache/spark/pull/29587#discussion_r489466321. This is ready for review