[GitHub] [spark] vitaliili-db commented on pull request #37631: [SPARK-40194][SQL] SPLIT function on empty regex should truncate trailing empty string.

2022-08-29 Thread GitBox
vitaliili-db commented on PR #37631: URL: https://github.com/apache/spark/pull/37631#issuecomment-1230981751 @cloud-fan thank you, that is a great suggestion. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [spark] vitaliili-db commented on pull request #37631: [SPARK-40194][SQL] SPLIT function on empty regex should truncate trailing empty string.

2022-08-26 Thread GitBox
vitaliili-db commented on PR #37631: URL: https://github.com/apache/spark/pull/37631#issuecomment-1228950512 @cloud-fan trailing empty string is not actually a bug, it has consistent behavior in all systems, e.g. `split("aaAbbAccA", "A")` gives same result in all systems => `['aa', 'bb', 'c

[GitHub] [spark] vitaliili-db commented on pull request #37631: [SPARK-40194][SQL] SPLIT function on empty regex should truncate trailing empty string.

2022-08-24 Thread GitBox
vitaliili-db commented on PR #37631: URL: https://github.com/apache/spark/pull/37631#issuecomment-1226095179 @cloud-fan other databases don't have `limit` parameter in `split` function. In addition a second parameter is a string in other systems as opposed to regex in Spark. Closest method

[GitHub] [spark] vitaliili-db commented on pull request #37631: [SPARK-40194][SQL] SPLIT function on empty regex should truncate trailing empty string.

2022-08-23 Thread GitBox
vitaliili-db commented on PR #37631: URL: https://github.com/apache/spark/pull/37631#issuecomment-1224996770 @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To