subject:"\[GitHub\] \[spark\] xinrong\-meng commented on a diff in pull request #38921\: \[SPARK\-41397\]\[CONNECT\]\[PYTHON\] Implement part of string\/binary functions"

[GitHub] [spark] xinrong-meng commented on a diff in pull request #38921: [SPARK-41397][CONNECT][PYTHON] Implement part of string/binary functions

2022-12-06 Thread GitBox

xinrong-meng commented on code in PR #38921: URL: https://github.com/apache/spark/pull/38921#discussion_r1041642310 ## python/pyspark/sql/tests/connect/test_connect_function.py: ## @@ -410,6 +410,67 @@ def test_aggregation_functions(self):

[GitHub] [spark] xinrong-meng commented on a diff in pull request #38921: [SPARK-41397][CONNECT][PYTHON] Implement part of string/binary functions

2022-12-05 Thread GitBox

xinrong-meng commented on code in PR #38921: URL: https://github.com/apache/spark/pull/38921#discussion_r1040281681 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -44,16 +44,16 @@ import