[GitHub] [spark] xinrong-meng commented on a diff in pull request #40684: [SPARK-41532][CONNECT][CLIENT] Add check for operations that involve multiple data frames

2023-05-02 Thread via GitHub
xinrong-meng commented on code in PR #40684: URL: https://github.com/apache/spark/pull/40684#discussion_r1183174669 ## python/pyspark/sql/connect/dataframe.py: ## @@ -249,14 +254,18 @@ def crossJoin(self, other: "DataFrame") -> "DataFrame": raise Exception("Cannot c

[GitHub] [spark] xinrong-meng commented on a diff in pull request #40684: [SPARK-41532][CONNECT][CLIENT] Add check for operations that involve multiple data frames

2023-05-02 Thread via GitHub
xinrong-meng commented on code in PR #40684: URL: https://github.com/apache/spark/pull/40684#discussion_r1183174981 ## python/pyspark/sql/connect/dataframe.py: ## @@ -249,14 +254,18 @@ def crossJoin(self, other: "DataFrame") -> "DataFrame": raise Exception("Cannot c

[GitHub] [spark] xinrong-meng commented on a diff in pull request #40684: [SPARK-41532][CONNECT][CLIENT] Add check for operations that involve multiple data frames

2023-05-03 Thread via GitHub
xinrong-meng commented on code in PR #40684: URL: https://github.com/apache/spark/pull/40684#discussion_r1183889165 ## python/pyspark/sql/connect/dataframe.py: ## @@ -249,14 +254,18 @@ def crossJoin(self, other: "DataFrame") -> "DataFrame": raise Exception("Cannot c

[GitHub] [spark] xinrong-meng commented on a diff in pull request #40684: [SPARK-41532][CONNECT][CLIENT] Add check for operations that involve multiple data frames

2023-05-03 Thread via GitHub
xinrong-meng commented on code in PR #40684: URL: https://github.com/apache/spark/pull/40684#discussion_r1183889165 ## python/pyspark/sql/connect/dataframe.py: ## @@ -249,14 +254,18 @@ def crossJoin(self, other: "DataFrame") -> "DataFrame": raise Exception("Cannot c

[GitHub] [spark] xinrong-meng commented on a diff in pull request #40684: [SPARK-41532][CONNECT][CLIENT] Add check for operations that involve multiple data frames

2023-05-03 Thread via GitHub
xinrong-meng commented on code in PR #40684: URL: https://github.com/apache/spark/pull/40684#discussion_r1183889165 ## python/pyspark/sql/connect/dataframe.py: ## @@ -249,14 +254,18 @@ def crossJoin(self, other: "DataFrame") -> "DataFrame": raise Exception("Cannot c