[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-18 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r634595619 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -123,6 +131,47 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-17 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r633761349 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -123,6 +131,42 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-17 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r633725651 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -123,6 +131,42 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-17 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r633729925 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -123,6 +131,42 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-17 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r633729925 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -123,6 +131,42 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-17 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r633729337 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -123,6 +131,42 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-17 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r633726039 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -703,40 +600,24 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-17 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r633725651 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -123,6 +131,42 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-11 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r630300027 ## File path: .idea/vcs.xml ## @@ -1,24 +1,16 @@ - Review comment: Oops! Good catch @otterc, thank you! -- This is an automated message

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-10 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r629498336 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -123,6 +131,54 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-05-10 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r629467040 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -228,117 +272,72 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-04-29 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r623195101 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -704,39 +577,25 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-04-29 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r623187485 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -270,38 +231,26 @@ class

[GitHub] [spark] xkrogen commented on a change in pull request #32389: [SPARK-35263] [TEST] Refactor ShuffleBlockFetcherIteratorSuite to reduce duplicated code

2021-04-29 Thread GitBox
xkrogen commented on a change in pull request #32389: URL: https://github.com/apache/spark/pull/32389#discussion_r623186492 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -1061,3 +857,73 @@ class