xuanyuanking commented on a change in pull request #27707: [SPARK-30958][SQL]
do not set default era for DateTimeFormatter
URL: https://github.com/apache/spark/pull/27707#discussion_r384422360
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -82,7 +81,14 @@ private object DateTimeFormatterHelper {
def buildFormatter(pattern: String, locale: Locale): DateTimeFormatter = {
val builder = createBuilder().appendPattern(pattern)
- toFormatter(builder, locale)
+ if (pattern.contains("y")) {
Review comment:
Only contains 'y' might be overkill? Should we skip for the cases that 'y'
in the escape for text? e.g `'year:' uuuu HH mm`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
