[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-25 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494027734 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1020,16 +1039,35 @@ class Analyzer( //

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-24 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494084571 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -861,15 +862,22 @@ class Analyzer(

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-23 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494027847 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -260,19 +264,47 @@ class

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-23 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494027734 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1020,16 +1039,35 @@ class Analyzer( //

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-23 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r494027786 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ## @@ -731,3 +732,11 @@ case class

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-23 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r493280633 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala ## @@ -0,0 +1,178 @@ +/* + * Licensed to

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-23 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r493280289 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamTableAPISuite.scala ## @@ -0,0 +1,178 @@ +/* + * Licensed to

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-23 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r493279886 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1020,16 +1031,28 @@ class Analyzer( //

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-23 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r493279767 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -895,10 +896,12 @@ class Analyzer( object

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-21 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r491893262 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -260,19 +264,47 @@ class

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-21 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r491893444 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -39,7 +39,7 @@ import

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-21 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r491893660 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProviderSuite.scala ## @@ -78,6 +78,22 @@ class

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490146443 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala ## @@ -475,6 +476,23 @@ final class DataStreamReader

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490141790 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala ## @@ -815,3 +815,26 @@ class

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490141319 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ## @@ -174,7 +174,7 @@ case class CreateViewCommand(

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490139894 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -942,6 +957,47 @@ class Analyzer( }

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490139471 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -846,9 +848,9 @@ class Analyzer( */

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490139132 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -475,6 +475,16 @@ class SessionCatalog(

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490139241 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -260,19 +264,47 @@ class

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490138919 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -942,6 +957,47 @@ class Analyzer( }

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490138823 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala ## @@ -815,3 +815,26 @@ class

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490138424 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProviderSuite.scala ## @@ -78,6 +78,22 @@ class

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-17 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r490138015 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -923,6 +925,19 @@ class Analyzer(

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r488433490 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala ## @@ -475,6 +476,23 @@ final class DataStreamReader

[GitHub] [spark] xuanyuanking commented on a change in pull request #29756: [SPARK-32885][SS] Add DataStreamReader.table API

2020-09-15 Thread GitBox
xuanyuanking commented on a change in pull request #29756: URL: https://github.com/apache/spark/pull/29756#discussion_r488416472 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -923,6 +925,19 @@ class Analyzer(