[GitHub] [spark] xuanyuanking commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

xuanyuanking commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-850078509 Thanks for the review and help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] xuanyuanking commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

xuanyuanking commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-849468978 @HeartSaVioR Sure, thanks for reminding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] xuanyuanking commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

xuanyuanking commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-847455327 ``` Sorry for late. I will find some time in the weekend to look at this. ``` No worries, thanks for the detailed review! Take your time. -- This is an automated

[GitHub] [spark] xuanyuanking commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

xuanyuanking commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-843247088 To provide more context for the functions in this PR, I created the WIP PR (#32582) and referenced the comment there. Please check whether we can ship this for now. Thanks

[GitHub] [spark] xuanyuanking commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

xuanyuanking commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-842119218 ``` About the file name, RocksDBFileManager.scala doesn't contain any RocksDBFileManager. Shall we rename it? ``` All these checkpointing metadata is for

[GitHub] [spark] xuanyuanking commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

xuanyuanking commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-842119218 ``` About the file name, RocksDBFileManager.scala doesn't contain any RocksDBFileManager. Shall we rename it? ``` All these checkpointing metadata is for

[GitHub] [spark] xuanyuanking commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

xuanyuanking commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-840445866 ``` there're some sorts of uncertainty during reviewing as there's no reference PR. In other words, we are reviewing methods which we don't have idea how these methods

[GitHub] [spark] xuanyuanking commented on pull request #32272: [SPARK-35172][SS] The implementation of RocksDBCheckpointMetadata

xuanyuanking commented on pull request #32272: URL: https://github.com/apache/spark/pull/32272#issuecomment-830078472 @HeartSaVioR Thanks for the advice. Comments have been resolved and yes, it makes sense to reflect them to the PRs. The current implementation for