[GitHub] [spark] yaooqinn commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
yaooqinn commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839530699 cc @cloud-fan @MrPowers @HyukjinKwon @maropu thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [spark] yaooqinn commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
yaooqinn commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839907616 thanks @dongjoon-hyun, I've updated PR with your comments addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [spark] yaooqinn commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
yaooqinn commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-840243173 > Ur, @yaooqinn . The R failure looks a little suspicious because it's consistent and relevant. It might be a side-effect in terms of test classes. Could you double-check it?

[GitHub] [spark] yaooqinn commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-13 Thread GitBox
yaooqinn commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-840410375 Thanks for the help ~ @dongjoon-hyun @HyukjinKwon @cloud-fan +1 for myself. merged to master -- This is an automated message from the Apache Git Service. To respond to