yaooqinn opened a new pull request #27258: [SPARK-30547][SQL] Add unstable annotation to the CalendarInterval class URL: https://github.com/apache/spark/pull/27258 ### What changes were proposed in this pull request? `CalendarInterval` is maintained as a private class but might be used in a public way by users e.g. ```scala scala> spark.udf.register("getIntervalMonth", (_:org.apache.spark.unsafe.types.CalendarInterval).months) scala> sql("select interval 2 month 1 day a").selectExpr("getIntervalMonth(a)").show +-------------------+ |getIntervalMonth(a)| +-------------------+ | 2| +-------------------+ ``` And it exists since 1.5.0, now we go to the 3.x era，may be it's time to make it public ### Why are the changes needed? make the interval more future-proofing ### Does this PR introduce any user-facing change? doc change ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> add ut.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
