[GitHub] [spark] yikf commented on pull request #31648: [SPARK-34541][CORE] Fixed an issue where data could not be cleaned up when unregisterShuffle.

yikf commented on pull request #31648: URL: https://github.com/apache/spark/pull/31648#issuecomment-786568485 open a PR [https://github.com/apache/spark/pull/31664](url) against master branch This is an automated message fro

[GitHub] [spark] yikf commented on pull request #31648: [SPARK-34541][CORE] Fixed an issue where data could not be cleaned up when unregisterShuffle.

yikf commented on pull request #31648: URL: https://github.com/apache/spark/pull/31648#issuecomment-786337598 > @yikf, can you open a PR against master branch? ok, should i close the currently PR? This is an automated

[GitHub] [spark] yikf commented on pull request #31648: [SPARK-34541][core]Fixed an issue where data could not be cleaned up when unregisterShuffle.

yikf commented on pull request #31648: URL: https://github.com/apache/spark/pull/31648#issuecomment-786334725 > The existing tests are not catching this issue - can you add something to ensure we test for this problem ? i will add the UT for this problem. --

[GitHub] [spark] yikf commented on pull request #31648: [SPARK-34541][core]Fixed an issue where data could not be cleaned up when unregisterShuffle.

yikf commented on pull request #31648: URL: https://github.com/apache/spark/pull/31648#issuecomment-786334052 > The change in `SortShuffleManager` looks good to me. However, we should add a UT to cover this. Also, I don't quite get how the change in `StringExpressionsSuite.scala` is relate

[GitHub] [spark] yikf commented on pull request #31648: [SPARK-34541][core]Fixed an issue where data could not be cleaned up when unregisterShuffle.

yikf commented on pull request #31648: URL: https://github.com/apache/spark/pull/31648#issuecomment-785929222 gentle ping @srowen , thanks for taking a look. This is an automated message from the Apache Git Service. To respon