[GitHub] [spark] zero323 commented on pull request #30382: [SPARK-33457][PYTHON] Adjust mypy configuration

zero323 commented on pull request #30382: URL: https://github.com/apache/spark/pull/30382#issuecomment-733566086 Thanks @Fokko and @HyukjinKwon! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] zero323 commented on pull request #30382: [SPARK-33457][PYTHON] Adjust mypy configuration

zero323 commented on pull request #30382: URL: https://github.com/apache/spark/pull/30382#issuecomment-732152729 > @zero323, let me know when you think this is ready. Looks fine to me. Thanks @HyukjinKwon. I went over all violations of `disallow_any_generics` and these are mostly

[GitHub] [spark] zero323 commented on pull request #30382: [SPARK-33457][PYTHON] Adjust mypy configuration

zero323 commented on pull request #30382: URL: https://github.com/apache/spark/pull/30382#issuecomment-727695282 > My only concern is the maintenance cost for being strict. If it doesn't add non-trivial overhead, I am good to be more strict on the type hints. For the first two

[GitHub] [spark] zero323 commented on pull request #30382: [SPARK-33457][PYTHON] Adjust mypy configuration

zero323 commented on pull request #30382: URL: https://github.com/apache/spark/pull/30382#issuecomment-727692318 FYI @Fokko @HyukjinKwon Still work in progress, any suggestions about desired flags (I considered `show_error_codes`, for clarity, and `disallow_any_generics`).