[GitHub] [spark] zhengruifeng commented on a change in pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

zhengruifeng commented on a change in pull request #30009: URL: https://github.com/apache/spark/pull/30009#discussion_r518645766 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/Instance.scala ## @@ -114,6 +133,74 @@ private[spark] object InstanceBlock { def bl

[GitHub] [spark] zhengruifeng commented on a change in pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

zhengruifeng commented on a change in pull request #30009: URL: https://github.com/apache/spark/pull/30009#discussion_r518626371 ## File path: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ## @@ -562,4 +562,22 @@ trait HasBlockSize extends Params {

[GitHub] [spark] zhengruifeng commented on a change in pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

zhengruifeng commented on a change in pull request #30009: URL: https://github.com/apache/spark/pull/30009#discussion_r518485738 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/Instance.scala ## @@ -114,6 +133,74 @@ private[spark] object InstanceBlock { def bl

[GitHub] [spark] zhengruifeng commented on a change in pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

zhengruifeng commented on a change in pull request #30009: URL: https://github.com/apache/spark/pull/30009#discussion_r518482624 ## File path: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ## @@ -562,4 +562,22 @@ trait HasBlockSize extends Params {

[GitHub] [spark] zhengruifeng commented on a change in pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

zhengruifeng commented on a change in pull request #30009: URL: https://github.com/apache/spark/pull/30009#discussion_r506167739 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/Instance.scala ## @@ -114,6 +133,62 @@ private[spark] object InstanceBlock { def bl

[GitHub] [spark] zhengruifeng commented on a change in pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

zhengruifeng commented on a change in pull request #30009: URL: https://github.com/apache/spark/pull/30009#discussion_r506032899 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ## @@ -199,14 +193,11 @@ class LinearSVC @Since("2.2.0") (

[GitHub] [spark] zhengruifeng commented on a change in pull request #30009: [SPARK-32907][ML] adaptively blockify instances - LinearSVC

zhengruifeng commented on a change in pull request #30009: URL: https://github.com/apache/spark/pull/30009#discussion_r503191442 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/Instance.scala ## @@ -100,6 +102,23 @@ private[spark] case class InstanceBlock( pri