zhengruifeng commented on a change in pull request #30013: URL: https://github.com/apache/spark/pull/30013#discussion_r503623615
########## File path: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala ########## @@ -400,10 +400,9 @@ class LogisticRegressionSuite extends MLTest with DefaultReadWriteTest { } test("thresholds prediction") { - val blr = new LogisticRegression().setFamily("binomial") + val blr = new LogisticRegression().setFamily("binomial").setThreshold(1.0) val binaryModel = blr.fit(smallBinaryDataset) - binaryModel.setThreshold(1.0) testTransformer[(Double, Vector)](smallBinaryDataset.toDF(), binaryModel, "prediction") { Review comment: master fails in this modified case: ![tx](https://user-images.githubusercontent.com/7322292/95806570-98567800-0d3a-11eb-9481-c9cd343cd57f.png) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org