subject:"\[GitHub\] \[spark\] zhengruifeng commented on a diff in pull request #38778\: \[SPARK\-41227\]\[CONNECT\]\[PYTHON\] Implement DataFrame cross join"

[GitHub] [spark] zhengruifeng commented on a diff in pull request #38778: [SPARK-41227][CONNECT][PYTHON] Implement DataFrame cross join

2022-11-30 Thread GitBox

zhengruifeng commented on code in PR #38778: URL: https://github.com/apache/spark/pull/38778#discussion_r1035853820 ## python/pyspark/sql/tests/connect/test_connect_basic.py: ## @@ -722,6 +722,19 @@ def test_write_operations(self): ndf = self.connect.read.table("parquet

[GitHub] [spark] zhengruifeng commented on a diff in pull request #38778: [SPARK-41227][CONNECT][PYTHON] Implement DataFrame cross join

2022-11-28 Thread GitBox

zhengruifeng commented on code in PR #38778: URL: https://github.com/apache/spark/pull/38778#discussion_r1034246368 ## python/pyspark/sql/tests/connect/test_connect_plan_only.py: ## @@ -58,6 +58,13 @@ def test_join_condition(self): )._plan.to_proto(self.connect)